Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checks are executed in different order on subsequent runs #39

Closed
v-zhuravlev opened this issue Apr 8, 2022 · 1 comment · Fixed by #93
Closed

Checks are executed in different order on subsequent runs #39

v-zhuravlev opened this issue Apr 8, 2022 · 1 comment · Fixed by #93

Comments

@v-zhuravlev
Copy link

Execution of dashboard-linter lint <dashboards.json>
prints output of checks executed in different order all the time.
suntala added a commit to suntala/dashboard-linter that referenced this issue Sep 6, 2022
@suntala
Report rules in sorted order
557eda5 
Resolves grafana#39.
 
The fix involves sorting the rules by name and then using this order to iterate over the rules and their associated results. The sorting for the results is already taken care of by `ByRule()`.

I didn't add any tests because the addition is comparable to the sorting being done in `ByRule()` for which there are no tests. 

Please let me know if you have any questions or any changes to suggest.
@suntala suntala mentioned this issue Sep 6, 2022
Merged
@suntala
Copy link
Contributor

suntala commented Sep 6, 2022

Hi, I would be interested in working on a fix for this. I have already opened a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report rules in sorted order suntala/dashboard-linter
2 participants
@v-zhuravlev @suntala