Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target idx not set for target-rate-interval-rule #69

Closed
rgeyer opened this issue Jun 8, 2022 · 0 comments · Fixed by #83
Closed

Target idx not set for target-rate-interval-rule #69

rgeyer opened this issue Jun 8, 2022 · 0 comments · Fixed by #83

Comments

@rgeyer
Copy link
Collaborator

rgeyer commented Jun 8, 2022 •
edited

When the rate-interval rule is triggered, it does not include the target idx, making it impossible to selectively exclude queries in the .lint file.

Example from the grafana/jsonnet-libs/consul-mixin.

[target-rate-interval-rule] 'Consul Overview': Dashboard 'Consul Overview', panel 'Latency' invalid PromQL query 'sum(rate(consul_http_request{job=~"$job"}[5m])) / sum(rate(consul_http_request{job=~"$job"}[5m]))': should use $__rate_interval
rgeyer added a commit that referenced this issue Jun 30, 2022
@rgeyer
Resolves #69
93cbf7e 
Drive-by fix for the target-promql rule
@rgeyer rgeyer mentioned this issue Jun 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include Target Idx in message for all target rules grafana/dashboard-linter
1 participant
@rgeyer