Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom name for the datasource template #101

Closed
wants to merge 1 commit into from

Conversation

kovaxur
Copy link

@kovaxur kovaxur commented Oct 20, 2022

Changed the datasource linter to allow any name for the datasource template using regexp.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Daniel Kovacs seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rgeyer
Copy link
Collaborator

rgeyer commented May 12, 2023

Hello @kovaxur, can you look at the implementation merged in #124 and see if it solves this problem for you?

The issue of allowing multiple data sources has been discussed, and #124 was the solution which got group consensus. While it would not allow any named variable for the data source, it will allow multiple, and tries to be reasonable about naming by enforcing consistency.

@kovaxur
Copy link
Author

kovaxur commented Feb 1, 2024

Yes, it's fine thanks.

@kovaxur kovaxur closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants