Add alert exclusion prerequisites #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added `Alert` filed to `ConfigurationEntry` is a prerequisite for letting Mixtool exclude Prometheus alerts from linting. The required logic for exclusions are contained within Mixtool.
Dasomeone
changed the title
Dasomeone
added a commit
to Dasomeone/mixtool
that referenced
this pull request
Jan 9, 2023
rgeyer
pushed a commit
to monitoring-mixins/mixtool
that referenced
this pull request
Jan 10, 2023
* Added idea IDE folder to gitignore * Added alert rule exclusion support Requires grafana/dashboard-linter#115 * Tidied up go.mod Tidied with compatibility with Go 1.17 * Updated to use latest dashboard-linter Changes include required prerequisites for alert exclusions * Updated golangci-lint version * Addressed PR comments * Added missing go.sum entry for sirupsen/logrus * Addressed comments pt. 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional field to the
ConfigurationEntrystruct, allowing forAlertoverrides to be defined in the .lint config files.The related lint exclusion logic will be contained entirely within Mixtool for the time being, as that is where the alert rules are enforced.
Additionally the .gitignore file has been updated to ignore standard IntelliJ IDEA artefacts