Linting: New rule for templates - Refresh is set to 'On Time Range Change' #119
+117
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgeyer
reviewed
Feb 28, 2023
There was a problem hiding this comment.
LGTM!
I've managed to forget this on a few previous rules, but...
Can you please add a doc file for the rule at docs/rules/template-on-time-change-reload.md?
It can be a copy/paste of the description if not much additional information is required. Tho for this one it may be worth briefly discussing why it's important to have this set to time-change rather than on-load.
I'll come over the top with a docs PR to get it up-to-date.
Thank you!
rgeyer
deleted the
gaantunes/new-lint-template-on-time-range=change-reload
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.