upgrade golangci-lint to 1.52 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgeyer
approved these changes
May 12, 2023
rgeyer
reviewed
May 12, 2023
lint/rule_target_job_instance.go
Outdated
| @@ -12,7 +12,7 @@ func newTargetRequiredMatcherRule(matcher string) *TargetRuleFunc { | |||
| name: fmt.Sprintf("target-%s-rule", matcher), | |||
| description: fmt.Sprintf("Checks that every PromQL query has a %s matcher.", matcher), | |||
| fn: func(d Dashboard, p Panel, t Target) Result { | |||
| // TODO: The RuleSet should be responsible for routing rule checks based on their query type (prometheus, loki, mysql, etc) | |||
There was a problem hiding this comment.
I presume that the TODOs were removed as a result of the updated linting? Can we override that rule?
All of the TODOs which were removed are still not complete, and.. I've been a poor maintainer in that they aren't tracked as issues either 🤦
There was a problem hiding this comment.
yes, we can override that rule - I'll do that
|
One question on the TODOs. I approved pre-maturely assuming that this only upgraded the linter, without necessarily having any code changes. |
gotjosh
added a commit
that referenced
this pull request
Aug 3, 2023
When attempting to get the configured unit of a panel, there's a chance that the field configuration is not on the dashboard definition. We should nil check this property before we attempt to access it. Looks like this was introduced in #127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #126