Ignored query field check for adhoc variables #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As stated in <grafana#41>, the linter will throw an error when the grafana dashboard has a variable of type "adhoc". This commit will ignore the query type check for "adhoc" variables and will fix the issue mentioned above.
|
It is my first commit in this repo, so I don't know if the changes make sense or not. Please propose an alternative solution in case this one is not ideal :) |
|
Hi @antoniocascais - thank you for you contribution! I think this makes perfect sense ;-) LGTM |
tomwilkie
approved these changes
Apr 8, 2022
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #41,
the linter will throw an error when the grafana dashboard has a variable
of type "adhoc".
This commit will ignore the query type check for "adhoc" variables and
will fix the issue mentioned above.
Fixes #41