Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dashboard template vars with multiple options. Resolves #43 #45

Merged
merged 4 commits into from
Apr 26, 2022

Conversation

rgeyer
Copy link
Collaborator

@rgeyer rgeyer commented Apr 22, 2022

This PR does some unmarshal magic to allow either a string. or an array of strings for text and value.

The TemplateValue struct remains unchanged. If the value is an array, the first element is used for the value.

@rgeyer rgeyer requested a review from tomwilkie April 22, 2022 19:29
lint/lint.go Outdated Show resolved Hide resolved
lint/lint.go Outdated Show resolved Hide resolved
Copy link
Contributor

@tomwilkie tomwilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nit

rgeyer and others added 2 commits April 26, 2022 07:45
Co-authored-by: Tom Wilkie <tomwilkie@users.noreply.github.com>
Co-authored-by: Tom Wilkie <tomwilkie@users.noreply.github.com>
@rgeyer
Copy link
Collaborator Author

rgeyer commented Apr 26, 2022

LGTM with minor nit

Ahh right, I suppose I wouldn't need a conditional if I'm returning an error 😂

@rgeyer rgeyer merged commit a747e60 into main Apr 26, 2022
@rgeyer rgeyer deleted the fix/tmpl_var_multichoice-43 branch April 26, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants