Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update prometheus #47

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Update prometheus #47

merged 1 commit into from
Apr 26, 2022

Conversation

roidelapluie
Copy link
Contributor

Signed-off-by: Julien Pivotto roidelapluie@o11y.eu

@roidelapluie roidelapluie mentioned this pull request Apr 26, 2022
Closed
@tomwilkie
Copy link
Contributor

This is a massive improvement, thank you so much @roidelapluie ❤️

rgeyer
rgeyer requested changes Apr 26, 2022
View reviewed changes
Copy link
Collaborator

@rgeyer rgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the tests caught some modules which weren't in the go.sum.

Can you run a go mod tidy in your branch, and commit the result. Happy to approve and merge at that point.

Thank you!

@roidelapluie
Update prometheus
6591e60 
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
@roidelapluie
Copy link
Contributor Author

Done

@rgeyer
Copy link
Collaborator

rgeyer commented Apr 26, 2022

Done

Thank you for the contribution!

@rgeyer rgeyer merged commit cfa907e into grafana:main Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgeyer rgeyer rgeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roidelapluie @tomwilkie @rgeyer