Add rule to check default time and refresh interval

[mshahzeb]

Reference issue:
#52

This rule checks if each dashboard has:

• A default time interval of 1h
• A default refresh interval of 5m

[CLAassistant]

All committers have signed the CLA.

[rgeyer]

The code looks good, however..

This is very opinionated, and does not necessarily improve dashboards in any tangible way.

In fact, for some dashboards with slow moving data (SCM releases which happen over hours, days, or weeks) these defaults wouldn't make any sense.

We use these defaults across all of the mixins/integrations for Grafana Cloud for the sake of uniformity, but we needn't necessarily impose this on all dashboards for all users.

What do you think?
@gaantunes @v-zhuravlev

[mshahzeb]

I guess this is more of an integration specific rule rather than a generic dashboard rule.

I think we are already doing that here in utils.libsonnet:
https://github.com/grafana/cloud-onboarding/blob/7473d9783afbf1a0a205b58c70ed8fe6be3ca8a1/integrations/util.libsonnet#L19

But its setting it to 30m and 30s refresh not 1h and 5m interval.

[rgeyer]

I guess this is more of an integration specific rule rather than a generic dashboard rule.

I think we are already doing that here in utils.libsonnet: https://github.com/grafana/cloud-onboarding/blob/7473d9783afbf1a0a205b58c70ed8fe6be3ca8a1/integrations/util.libsonnet#L19

But its setting it to 30m and 30s refresh not 1h and 5m interval.

Right. We should discuss what the expectation is here, and resolve in cloud-onboarding. This one PR can be closed tho.