Add target histogram rule #91
Open
+152
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llowing recording rules to be used
beorn7
requested changes
Jul 21, 2022
There was a problem hiding this comment.
As discussed on Slack, it's perfectly reasonable to access a ..._bucket metric outside of a histogram_quantile argument. It's more the other way around: The histogram_quantile function can only reasonably act on ..._bucket time series (with only very obscure exceptions).
| } | ||
|
|
||
| err = parser.Walk(inspector(func(node parser.Node, parents []parser.Node) error { | ||
| // We're looking for either a VectorSelector. This skips any other node type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #56.
Fairly simple, and literal check that finds any metric/series containing
_bucketand ensures that it is inside of a function call tohistogram_quantile.There was some internal slack discussion about forthcoming features which may need to be accounted for in the future, but we will wait until those are finalized before addressing them in the rules.