This repository has been archived by the owner on May 5, 2023. It is now read-only.
Extend spec of graph panel to expose fieldConfig #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had quite some trouble making a graph panel use a unit using grafonnet-7.0, as the documentation does not hint at how to do that and trying to do it using ".addYaxis" always resulted in empty graphs. In the stats panel this can be achieved using
setFieldConfig
, but the graph panel does not have this method.So here is a PR, which extends the graph panel spec, by adding min, max and unit to the fieldConfig defaults, which in turn makes the generated Jsonnet code for the graph panel have a
setFieldConfig
method, which allows globally setting the unit for the graph.I tested this against my 7.4.2 grafana, and it works and it does, what I need...
I have no idea, if this is even remotely the right thing to do, but I'll take pointers to how to do it, if it is wrong. ;-)