Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: move from grafana-plugin-sdk-go/data #12

Merged
merged 2 commits into from
May 2, 2023
Merged

Docs: move from grafana-plugin-sdk-go/data #12

merged 2 commits into from
May 2, 2023

Conversation

kylebrandt
Copy link
Collaborator

No description provided.

yesoreyeram
yesoreyeram requested changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@yesoreyeram yesoreyeram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move this to /docs/contract/ folder so that it will become easier to add more docs later?

@kylebrandt
Copy link
Collaborator Author

kylebrandt commented May 2, 2023 •
edited

can we move this to /docs/contract/ folder so that it will become easier to add more docs later?

Will do, also I have not done GH pages in ages - does this need to go anywhere special?

@yesoreyeram
Copy link
Collaborator

docs is fine for gh-pages but to make it future proof i suggested that. I will make a follow-up PR to make the gh-pages work properly.

@kylebrandt kylebrandt merged commit c58cf49 into main May 2, 2023
2 checks passed
@kylebrandt kylebrandt deleted the docs branch May 2, 2023 16:41
@yesoreyeram
Copy link
Collaborator

It is now live in https://grafana.github.io/dataplane/contract/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesoreyeram yesoreyeram yesoreyeram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kylebrandt @yesoreyeram