Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestExampleData: Add json frame examples of datatypes and go lib for examples #5

Merged
merged 35 commits into from
Mar 22, 2023
Merged

TestExampleData: Add json frame examples of datatypes and go lib for examples #5

merged 35 commits into from
Mar 22, 2023

Conversation

kylebrandt
Copy link
Collaborator

@kylebrandt kylebrandt commented Mar 2, 2023 •
edited

Example of data within the dataplane contract in json files.

Also includes a go library for getting these examples.

Intended uses:

  • Tests
  • Mock and/or testdata datasources
  • Generating example dashboards

@yesoreyeram
Copy link
Collaborator

love it. This will eventually allows us perform e2e tests via mock datasource.

nit: Can you change the folder name testExampleData into testdata/contract/ for consistency?

kylebrandt and others added 23 commits March 3, 2023 13:58
@kylebrandt
(wip) code to get examples with frames
ddd7522 
and encoding example info in custom frame metadata
@kylebrandt
switch to embed
4626146
@kylebrandt
change structure
15b4443
@kylebrandt
change test
e6e941c
@kylebrandt
add collection layer
2918c26
@kylebrandt
remove silly map
9f8afdd
@kylebrandt
add filtering
dd714ea
@kylebrandt
comment/readme updates
4b669a0
@kylebrandt
Add collectionVersion property
152eadc
@kylebrandt
clarify RefID, reread frames so Frames() return can be mutated
d46d1ef
@yesoreyeram
mono repo setup for testexampledata (#7)
86f3beb
@kylebrandt
latest sdk
6082f7f
@kylebrandt
add sorting
90be1e0
@kylebrandt
start adding timeseries examples
ddac7f8
@kylebrandt
more time series long examples
0714699
@kylebrandt
fix some typos and add an example
5b64eb3
@kylebrandt
some more ts wide examples
363135a
@kylebrandt
some more ts wide examples (remainder fields)
9853693
@kylebrandt
add ts multi example
037f4f0
@kylebrandt
add "extended_valid" collections
a129068
@kylebrandt
more tswide examples
41cd862
@kylebrandt
json files prettier
5fc8cdd
@kylebrandt
misc fixes
2d83f1e
@kylebrandt kylebrandt changed the title TestExampleData: (WIP) Add json frame examples of datatypes TestExampleData: Add json frame examples of datatypes and go lib for examples Mar 8, 2023
@kylebrandt kylebrandt marked this pull request as ready for review March 8, 2023 20:27
@kylebrandt kylebrandt requested review from ryantxu, yesoreyeram and a team March 8, 2023 20:27
yesoreyeram
yesoreyeram reviewed Mar 20, 2023
View reviewed changes
sdata/reader/play_test.go Outdated Show resolved Hide resolved
examples/package.json Outdated Show resolved Hide resolved
kylebrandt added a commit that referenced this pull request Mar 22, 2023
@kylebrandt
sdata/reader: Add test using examples
7c71562 
extracted from #5
@kylebrandt
remove examples test from sdata
6f89070 
moved to another branch
@kylebrandt kylebrandt merged commit 5fb4468 into main Mar 22, 2023
@kylebrandt kylebrandt deleted the testExampleData branch March 22, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesoreyeram yesoreyeram yesoreyeram approved these changes

@ryantxu ryantxu Awaiting requested review from ryantxu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kylebrandt @yesoreyeram