Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multi-stage Docker builds for compiling executables #29

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

radiohead
Copy link
Contributor

What

This PR makes builds use Docker containers for compiling executables via Docker multi-stage builds.

Why

Compiling in a container ensures that build environment is always consistent with runtime environment.

@radiohead radiohead requested a review from marefr April 12, 2021 08:59
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@radiohead radiohead merged commit 56d391e into master Apr 12, 2021
@radiohead radiohead deleted the feature/build-in-docker branch April 12, 2021 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants