Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade pysaml2 to 7.4.2 #204

Closed
wants to merge 1 commit into from
Closed

Conversation

mvbattista
Copy link
Contributor

Add support for xmlsec1 v.1.3.x

Add support for xmlsec1 v.1.3.x
@CLAassistant
Copy link

CLAassistant commented Sep 8, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mvbattista
Copy link
Contributor Author

Mentioning @mostafa for review.

@mostafa
Copy link
Member

mostafa commented Sep 8, 2023

Hey @mvbattista,

Thanks for your contribution! New versions of pysaml2 are not backward compatible with Python 3.7 and 3.8, so I have to keep this back until we remove support for those as well. Plus, it breaks the builds.

@github-actions
Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the no-pr-activity Stale action label Oct 24, 2023
@mostafa mostafa added awaiting-approval Stale action and removed no-pr-activity Stale action labels Oct 24, 2023
@mostafa mostafa added work-in-progress Stale action and removed awaiting-approval Stale action labels Nov 16, 2023
@mostafa mostafa mentioned this pull request Nov 16, 2023
@mostafa
Copy link
Member

mostafa commented Nov 16, 2023

Hey @mvbattista,

Thanks for your contribution! I have cherry-picked your commit in #218 and I'll close this.

@mostafa mostafa closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-in-progress Stale action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants