[Trace] Support opentelemetry in dskit #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ying-jeanne
commented
Jun 28, 2023
| @@ -108,3 +118,5 @@ replace k8s.io/client-go v12.0.0+incompatible => k8s.io/client-go v0.21.4 | |||
| // Replace memberlist with our fork which includes some fixes that haven't been | |||
| // merged upstream yet. | |||
| replace github.com/hashicorp/memberlist => github.com/grafana/memberlist v0.3.1-0.20220708130638-bd88e10a3d91 | |||
|
|
|||
| replace github.com/weaveworks/common => ../common | |||
There was a problem hiding this comment.
replace in purpose, wait pr in common to be merged
|
see #385, for the final migration code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This pull request (PR) aims to enhance the functionality of the dskit library by providing a distinct spanlogger and instrument function. With the recent PR in weaveworks/common (link), it is now possible to utilize both opentracing and opentelemetry simultaneously, thanks to a bridge implementation. This PR in dskit enables services using dskit to seamlessly transition to opentelemetry.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]