Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Randomize ports when running server tests. #393

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Randomize ports when running server tests. #393

merged 3 commits into from
Oct 6, 2023

Conversation

pstibrany
Copy link
Member

Randomize ports when running server tests. This will hopefully fix some flaky tests.

--- FAIL: TestStopWithDisabledSignalHandling (0.00s)
    --- FAIL: TestStopWithDisabledSignalHandling/signals_disabled (0.00s)
        server_test.go:800: 
            	Error Trace:	/drone/src/server/server_test.go:800
            	            				/drone/src/server/server_test.go:819
            	Error:      	Received unexpected error:
            	            	listen tcp 127.0.0.1:9198: bind: address already in use
            	Test:       	TestStopWithDisabledSignalHandling/signals_disabled

pracucci
pracucci approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, LGTM!

server/server_test.go Outdated Show resolved Hide resolved
@pstibrany pstibrany enabled auto-merge (squash) October 6, 2023 09:47
@pstibrany pstibrany merged commit ad2fd7e into main Oct 6, 2023
2 of 3 checks passed
@pstibrany pstibrany deleted the use-random-ports-for-tests branch October 6, 2023 09:47
ying-jeanne pushed a commit that referenced this pull request Nov 2, 2023
@pstibrany @ying-jeanne
Randomize ports when running server tests. (#393)
a0c6804 
* Randomize ports when running tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pstibrany @pracucci