crypto/tls/test: server listens on localhost #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the build failure is a flake: #398 |
charleskorn
reviewed
Oct 10, 2023
| @@ -55,21 +55,21 @@ func (h *grpcHealthCheck) Watch(_ *grpc_health_v1.HealthCheckRequest, _ grpc_hea | |||
| return status.Error(codes.Unimplemented, "Watching is not supported") | |||
| } | |||
|
|
|||
| func getLocalHostPort() (int, error) { | |||
| func getLocalHostPort() (*net.TCPAddr, error) { | |||
There was a problem hiding this comment.
Should we rename this method now that it's no longer returning only the port? getLocalHostAddr perhaps?
kevinburkesegment
force-pushed
the
tests-0000-two
branch
from
ce38a62
to
2b254fc
Compare
Previously, the test server would bind to all interfaces, which leads to a very annoying error message on Mac computers, and may expose the server to public access which can only be a bad thing, in a test context.
kevinburkesegment
force-pushed
the
tests-0000-two
branch
from
2b254fc
to
c25af1d
Compare
charleskorn
approved these changes
Oct 10, 2023
ying-jeanne
pushed a commit
that referenced
this pull request
Nov 2, 2023
Previously, the test server would bind to all interfaces, which leads to a very annoying error message on Mac computers, and may expose the server to public access which can only be a bad thing, in a test context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the test server would bind to all interfaces, which leads to a very annoying error message on Mac computers, and may expose the server to public access which can only be a bad thing, in a test context.
Updates #381.