Improve TestSpreadMinimizingTokenGenerator_GetMissingTokens #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
charleskorn
approved these changes
Oct 10, 2023
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
ying-jeanne
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Improve TestSpreadMinimizingTokenGenerator_GetMissingTokens Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> * Fixing review findings Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com> --------- Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
It has been reported that
TestSpreadMinimizingTokenGenerator_GetMissingTokensis flaky. After a more detailed analysis, it has been noticed that in an unlucky case a generation of 3 random integeresactually returns an array with a repeated element. This is the main cause of the problem and it has been fixed by this PR.
Which issue(s) this PR fixes:
Fixes #398
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]