Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to configure grpc.NumStreamWorkers() #400

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

colega
Copy link
Contributor

@colega colega commented Oct 10, 2023

What this PR does:

Adds a configuration flag to set the grpc.NumStreamWorkers option.
I've called the option grpc.server.num-workers as it's the number of workers for the server, I don't think the word stream helps there.

Which issue(s) this PR fixes:

Internal.

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
@colega colega marked this pull request as ready for review October 10, 2023 09:21
@colega colega merged commit 9b82fbd into main Oct 10, 2023
3 checks passed
@colega colega deleted the configure-grpc-server-workers branch October 10, 2023 09:26
ying-jeanne pushed a commit that referenced this pull request Nov 2, 2023
* Add flag to configure grpc.NumStreamWorkers()

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

* Update CHANGELOG.md

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>

---------

Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants