DoUntilQuorum: don't use non-zone-aware logging when all zones are required for quorum
#403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskorn
force-pushed
the
charleskorn/dont-spam-trace-events
branch
from
3737ba8
to
c1ad005
Compare
Co-authored-by: Joshua Hesketh <josh@hesketh.net.au>
ying-jeanne
pushed a commit
that referenced
this pull request
Nov 2, 2023
…required for quorum (#403) * Add `ReplicationSet.ZoneAwarenessEnabled` field * Use zone-aware context handling and logging even if no unavailable zones are permitted. * Add changelog entry * Update ring/replication_set.go Co-authored-by: Joshua Hesketh <josh@hesketh.net.au> --------- Co-authored-by: Joshua Hesketh <josh@hesketh.net.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR fixes an issue where
DoUntilQuorummay generate more log messages and span events than expected when zone-awareness is enabled but all healthy zones are required for quorum. (For example, zone-awareness is enabled, three zones are running with 100 instances each, but one instance in the first zone is unavailable, so all instances in the other two zones are required for quorum.)Previously, if zone-awareness was enabled and all healthy zones were required for quorum, both
ReplicationSet.MaxErrorsandReplicationSet.MaxUnavailableZoneswould be 0.DoUntilQuorumwould then default to non-zone-aware mode. In non-zone-aware mode,DoUntilQuorumlogs astarting request to instancemessage for every instance.In contrast, in zone-aware mode,
DoUntilQuorumlogs astarting requests to zonemessage for each unique zone.In the example above, with all instances healthy,
DoUntilQuorumwould log two or threestarting requests to zonemessages, but as soon as one instance becomes unhealthy, a subsequentDoUntilQuorumcall would log 200starting request to instancemessages.This PR changes the behaviour of
DoUntilQuorumto always run in zone-aware mode if zone-awareness is enabled, even if bothReplicationSet.MaxErrorsandReplicationSet.MaxUnavailableZonesare 0.Which issue(s) this PR fixes:
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]