Allow defining config name for runtime config metric #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
replay
changed the title
colega
approved these changes
Oct 16, 2023
3 tasks
ying-jeanne
pushed a commit
that referenced
this pull request
Nov 2, 2023
* set config label on runtime config manager metrics Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> * pass runtime config name into runtime config manager Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com> --------- Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary when one process wants to instantiate multiple instances of the runtime config manager.
Without this, they'd have to wrap the registerer that gets passed into
New()with a prefix, but this means that alerts on the metric exported by the runtime config manager can't be re-used.When updating the vendored dskit, we'll define a name in each place that uses it.