Server: Raise default max-concurrent-streams following change in gRPC #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gRPC release 1.58.3 changed the meaning of this setting from a per-client limit to a server-wide limit, thus 100 is very low as a default. Depending on what your server does, any default will be wrong, but I propose 10,000 as a level which should not constrict most people, which was the intention of the previous default of 100 per client. https://github.com/grpc/grpc-go/releases/tag/v1.58.3 Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
colega
reviewed
Oct 18, 2023
Co-authored-by: Oleg Zaytsev <mail@olegzaytsev.com>
|
It seems I misunderstood the change - it is still a limit per-connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
gRPC release 1.58.3 changed the meaning of this setting from a per-client limit to a server-wide limit, thus 100 is very low as a default.
Depending on what your server does, any default will be wrong, but I propose 10,000 as a level which should not constrict most people, which was the intention of the previous default of 100 per client.
https://github.com/grpc/grpc-go/releases/tag/v1.58.3
Checklist
CHANGELOG.mdupdated