Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address post-merge feedback on #404 #413

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Address post-merge feedback on #404 #413

merged 3 commits into from
Oct 19, 2023

Conversation

charleskorn
Copy link
Contributor

@charleskorn charleskorn commented Oct 19, 2023 •
edited

What this PR does:

This PR addresses two comments from @pracucci after #404 was merged.

Which issue(s) this PR fixes:

(none)

Checklist

  • [n/a] Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@charleskorn charleskorn mentioned this pull request Oct 19, 2023
Merged
2 tasks
pracucci
pracucci approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charleskorn charleskorn enabled auto-merge (squash) October 19, 2023 22:53
@charleskorn charleskorn merged commit 482adfe into main Oct 19, 2023
3 checks passed
@charleskorn charleskorn deleted the charleskorn/404-feedback branch October 19, 2023 22:59
ying-jeanne pushed a commit that referenced this pull request Nov 2, 2023
@charleskorn @ying-jeanne
Address post-merge feedback on #404 (#413)
cfc88c2 
* Don't log errors twice.

* Log terminal errors as warnings, not errors

* Update changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@charleskorn @pracucci