Memcached: allow to configure write and read buffer size #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <marco@pracucci.com>
pracucci
force-pushed
the
allow-to-customise-memcached-read-write-buffer
branch
from
d50af07
to
f2192ba
Compare
3 tasks
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
56quarters
approved these changes
Oct 23, 2023
ying-jeanne
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Memcached: allow to configure write and read buffer size Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed TestBackendConfig_Validate Signed-off-by: Marco Pracucci <marco@pracucci.com> * Revendored gomemcache Signed-off-by: Marco Pracucci <marco@pracucci.com> * Trigger CI Signed-off-by: Marco Pracucci <marco@pracucci.com> * Trigger CI Signed-off-by: Marco Pracucci <marco@pracucci.com> --------- Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
I noticed the memcached client library uses a default 4KB buffer for the read and write. However, in Mimir we transfer way bigger items and I would like to test whether increasing the buffer size will result into better performance. For this reason, I've made it configurable in grafana/gomemcache#15 and I'm proposing to make the configuration option available through YAML / CLI flags (experimental config option).
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]