httpgrpc: Add headers in http grpc error #416
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ying-jeanne
force-pushed
the
add-header-in-httpgrpc-response
branch
from
cbaa6c6
to
aea3890
Compare
| @@ -28,6 +28,14 @@ func Errorf(code int, tmpl string, args ...interface{}) error { | |||
| }) | |||
| } | |||
|
|
|||
| func ErrorfWithHeaders(code int, headers []*Header, tmpl string, args ...interface{}) error { | |||
There was a problem hiding this comment.
Where would this method be called from?
I am currently getting rid of all httpgrpc.Errorf() calls in ingester and distributor. Would like to understand where this new method would be needed.
There was a problem hiding this comment.
after our conversation, I think this PR is no longer needed. Thanks for the headsup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In the context of incorporating a retry-after mechanism for all errors that can be recovered, we must compute the retry-after duration within the distributor and include it in the httpgrpc error. This PR focuses on encoding the header within the httpgrpc error, enabling it to be subsequently transmitted to the http response.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]