Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hedgedhttp: bump cristalhq/hedgedhttp #418

Merged
merged 3 commits into from
Oct 27, 2023
Merged

hedgedhttp: bump cristalhq/hedgedhttp #418

merged 3 commits into from
Oct 27, 2023

Conversation

cristaloleg
Copy link
Contributor

@cristaloleg cristaloleg commented Oct 26, 2023 •
edited

What this PR does:
Updates cristalhq/hedgedhttp library to use new API. Old is still present but probably will be removed in the future.

Which issue(s) this PR fixes:

Fixes #

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

aknuds1
aknuds1 reviewed Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@aknuds1 aknuds1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it documented anywhere that hedgedhttp.NewRoundTripper is deprecated ("old API")? I can't see it in the docs.

Also, can this be moved out of draft mode?

@aknuds1 aknuds1 requested a review from a team October 27, 2023 06:32
@cristaloleg
Copy link
Contributor Author

Hey,

Is it documented anywhere that hedgedhttp.NewRoundTripper

Currently not but as the cristalhq/hedgedhttp author I can confirm that deprecation will happen in the next release. Not because it's wrong or bad, just because hedgedhttp.New (and hedgedhttp.Client as a result) implements http.RoundTripper.

Also, can this be moved out of draft mode?

I haven't updated CHANGELOG file and haven't verified are there other things to do to get accepted. If it looks good for you - you/me can change the status.

@cristaloleg cristaloleg marked this pull request as ready for review October 27, 2023 07:20
aknuds1
aknuds1 reviewed Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@aknuds1 aknuds1 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT, the bump is straightforward, but I don't think a changelog entry is warranted as it shouldn't make any functional difference. Looks acceptable otherwise.

CHANGELOG.md Outdated Show resolved Hide resolved
@cristaloleg @aknuds1
Update CHANGELOG.md
4619865 
Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
aknuds1
aknuds1 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aknuds1 aknuds1 merged commit 71a732f into grafana:main Oct 27, 2023
2 checks passed
@aknuds1 aknuds1 added the chore label Oct 27, 2023
@cristaloleg cristaloleg deleted the bump-hedgedhttp branch October 27, 2023 08:09
@cristaloleg cristaloleg mentioned this pull request Oct 27, 2023
Draft
8 tasks
ying-jeanne pushed a commit that referenced this pull request Nov 2, 2023
@cristaloleg @aknuds1 @ying-jeanne
hedgedhttp: bump cristalhq/hedgedhttp (#418)
8af0f97 
* hedgedhttp: bump cristalhq/hedgedhttp

---------

Co-authored-by: Arve Knudsen <arve.knudsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cristaloleg @CLAassistant @aknuds1