Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod, .drone: update to Go 1.20 and 1.21 #420

Merged
merged 6 commits into from
Oct 27, 2023
Merged

go.mod, .drone: update to Go 1.20 and 1.21 #420

merged 6 commits into from
Oct 27, 2023

Conversation

cristaloleg
Copy link
Contributor

What this PR does:
Updates Go version in go.mod to 1.20. Updates drone config to use the latest images and drop the old 1.19.

Which issue(s) this PR fixes:

Fixes #419

Checklist

  • Tests updated
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

aknuds1
aknuds1 reviewed Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the changelog entry mentioning Go 1.19 to mention Go 1.20 and point to this PR instead?

aknuds1
aknuds1 reviewed Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments about obtaining a seeded random generator.

ring/ring_test.go Outdated Show resolved Hide resolved
metrics/tenant_registries_test.go Outdated Show resolved Hide resolved
@aknuds1 aknuds1 added the chore label Oct 27, 2023
pstibrany
pstibrany reviewed Oct 27, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pstibrany
pstibrany approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm.

@aknuds1 aknuds1 merged commit 7d64494 into grafana:main Oct 27, 2023
2 checks passed
@cristaloleg cristaloleg deleted the bump-go1.20 branch October 27, 2023 08:59
ying-jeanne pushed a commit that referenced this pull request Nov 2, 2023
@cristaloleg @ying-jeanne
go.mod, .drone: update to Go 1.20 and 1.21 (#420)
303f2e8 
* go.mod, .drone: update to Go 1.20 and 1.21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes

@pstibrany pstibrany pstibrany approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump to Go 1.20 in go.mod
3 participants
@cristaloleg @aknuds1 @pstibrany