Add option to configure ReadHeaderTimeout for HTTP server #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
approved these changes
Oct 30, 2023
| IdleTimeout: cfg.HTTPServerIdleTimeout, | ||
| Handler: middleware.Merge(httpMiddleware...).Wrap(router), | ||
| ReadTimeout: cfg.HTTPServerReadTimeout, | ||
| ReadHeaderTimeout: cfg.HTTPServerReadHeaderTimeout, |
There was a problem hiding this comment.
Add a comment to explain why we want to set the read header timeout.
There was a problem hiding this comment.
PTAL to see if new descriptions make sense.
|
Converted to draft again. As it is now, the field descriptions and CHANGELOG entry is wrong. Image explaining the timeouts: |
Updated the description of fields and changelog entry. |
pstibrany
changed the title
ying-jeanne
pushed a commit
that referenced
this pull request
Nov 2, 2023
* By setting ReadHeaderTimeout, ReadTimeout is only used for body. * Add config option for read header timeout. * Add CHANGELOG.md entry. * Fix documentation and changelog entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: Set read header timeout explicitly. This allows setting of shorter timeout for headers, and not using entire
-server.http-read-timeout.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]