Remove an un-necessary go routine in a test #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
aknuds1
approved these changes
Nov 17, 2023
charleskorn
reviewed
Nov 19, 2023
| go func() { | ||
| wg.Wait() | ||
| }() | ||
| wg.Wait() |
There was a problem hiding this comment.
Why do we need to wait on the WaitGroup at all? Won't the select below block?
If you want to ensure the goroutine terminates, perhaps moving this below the select would be best. Or this could even be simplified to have the goroutine close a channel once the loop is complete, and then the test can wait for that channel to be closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
TestBatchTracker_Recordintroduced in #430 contains an un-necessary go routine in which we just wait for aWaitGroup, as remarked here. This PR removes that go routine.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]