encapsulate httpgrpc to http request unwrapping as public fn #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoposa
commented
Nov 17, 2023
| // HTTPRequest wraps an ordinary HTTPRequest with a gRPC one | ||
| func HTTPRequest(r *http.Request) (*httpgrpc.HTTPRequest, error) { | ||
| // WrapHTTPRequest wraps an ordinary http.Request up into an httpgrpc.HTTPRequest | ||
| func WrapHTTPRequest(r *http.Request) (*httpgrpc.HTTPRequest, error) { |
There was a problem hiding this comment.
there is one usage of this in Mimir/GEM that would need updated with the new name, but if we're super adverse to changing that, it could remain as it was.
There was a problem hiding this comment.
It's not "wrapping" (new message doesn't keep original request), but full conversion, so the new naming is wrong misleading.
leizor
reviewed
Nov 18, 2023
Comment on lines
+188
to
+191
| toHeader(r.Headers, req.Header) | ||
| req = req.WithContext(ctx) | ||
| req.RequestURI = r.Url | ||
| req.ContentLength = int64(len(r.Body)) |
There was a problem hiding this comment.
We don't need to repeat these steps in Handle above, do we?
francoposa
deleted the
francoposa/httpgrpc-encapsulate-httpgrpc-to-http-request-as-public-fn
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
this moves the httpgrpc request -> http request conversion to a public func, and renames the existing opposite conversion func to match.
For the multi-dimensional scheduler queue work, we need to route queries based on whether they will touch ingesters or store gateways.
We want to re-use the existing code for this for obvious reasons - Mimir
querymiddlewaresplit and cache functionality already handles this by converting anhttp.Requestto aquerymiddleware.Requesttype representing either an instant or range request.In the scheduler queueing code, we are starting with the httpgrpc request rather than the unwrapped
http.Requestso we need to unwrap it ourselves using this newly-exposed func before we can re-use the other querymiddleware code mentioned above.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]