refactor httpgrpc request/response utils from httpgrpc/server to httpgrpc #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
Nov 20, 2023
Co-authored-by: Peter Štibraný <pstibrany@gmail.com>
pstibrany
approved these changes
Nov 20, 2023
|
I'd also suggest to please check if Mimir, Loki, Tempo or Pyroscope use any of moved methods. |
francoposa
deleted the
francoposa/refactor-httpgrpc-utils-from-server-to-httpgrpc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to feedback on grafana/mimir#6694, tried to tee up a little more descriptive naming.
Having these utils be used prefixed with package name
httpgrpcallows for clearer usage without a longer name:httpgrpc.FromHTTPRequestandhttpgrpc.ToHTTPRequest, rather thanserver.FromHTTPRequestandserver.ToHTTPRequest.What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]