Use seeded random generator in tests. #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| @@ -34,8 +34,3 @@ func TestRandomTokenGenerator_IgnoresOldTokens(t *testing.T) { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // GenerateTokens generates numTokens unique, random and sorted tokens for testing purposes. | |||
| func GenerateTokens(tokensCount int, takenTokens []uint32) Tokens { | |||
There was a problem hiding this comment.
[nit] WDYT if we keep this function, and initialize the token generator inside it?
This way the diff in ring_test.go would be minimizined.
There was a problem hiding this comment.
Many tests call that function multiple times, which would then initialize multiple generators. I tried to avoid having too many generators per test, although there may be some tests where there is more than one used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR replaces use of
GenerateTokensin tests with generator initialized byinitTokenGenerator(b), which also logs used seed.Extracted from #433, to make it smaller.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]