ClientPool: expose method to remove client by value #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a method to remove a client from the pool only if it already hasn't been removed. This helps in cases where concurrent users of the client want to remove the same client instance and then immediately after that get a new instance. Clients can remove each other's new instances since the access to the pool is serialized via the mutex. If the clients retry removing a client on failed connections this can lead to live-lock.
dimitarvdimitrov
deleted the
dimitar/client-pool/remove-client-by-equality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method to remove a client from the pool only if it already hasn't been removed.
This helps in cases where concurrent users of the client want to remove the same client instance and then immediately after that get a new instance. Clients can remove each other's new instances since the access to the pool is serialized via the mutex. If the clients retry removing a client on failed connections this can lead to live-lock.