Token ranges: test different instance states. #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboreham
reviewed
Nov 24, 2023
pracucci
reviewed
Nov 24, 2023
ring/token_range_test.go
Outdated
| @@ -195,6 +200,12 @@ func TestCheckingOfKeyOwnership(t *testing.T) { | |||
|
|
|||
| // Generate ring | |||
| ringDesc := &Desc{Ingesters: generateRingInstances(gen, instancesPerZone*numZones, numZones, numTokens)} | |||
| // Switch states of some ingesters | |||
There was a problem hiding this comment.
I have a feedback similar to Bryan's one. The comment says "some ingesters" but I read the code as "all ingesters".
Good point. I've added test without states randomization too. |
pracucci
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR modifies
TestCheckingOfKeyOwnershiptest to randomize instance states.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]