Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TokenRanges.Equal #442

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Add TokenRanges.Equal #442

merged 2 commits into from
Nov 24, 2023

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented Nov 24, 2023 •
edited

What this PR does:

Add TokenRanges.Equal method. Mimir uses this to check if ingester's token ranges have changed.

Checklist

  • Tests updated
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

bboreham
bboreham reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add to the description a few words why you want this?

@pstibrany
Copy link
Member Author

Could you add to the description a few words why you want this?

Added: "Mimir uses this to check if tokens have changed.".

@pstibrany pstibrany merged commit c844f48 into main Nov 24, 2023
3 checks passed
@pstibrany pstibrany deleted the token-ranges-equal branch November 24, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham left review comments

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pstibrany @pracucci @bboreham