Add ability to log all source hosts from http header instead of only the first one. #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bubu11e
force-pushed
the
souce_ip_full_extract
branch
2 times, most recently
from
7050520
to
d6d94e0
Compare
bubu11e
force-pushed
the
souce_ip_full_extract
branch
2 times, most recently
from
c651602
to
3e93078
Compare
This test named "multiple matching entries in the header, only first used" Should test against one header containing multiple IPs and not multiple headers containing a single IP. Signed-off-by: julien.girard <julien.girard@ovhcloud.com>
bubu11e
force-pushed
the
souce_ip_full_extract
branch
from
3e93078
to
97616ef
Compare
56quarters
approved these changes
Jan 26, 2024
bubu11e
force-pushed
the
souce_ip_full_extract
branch
from
97616ef
to
6e41b5d
Compare
…ead of only the first one This commit add the hability to extract all hosts from a custom header or the standard one Forwarded, X-Real-IP, X-Forwraded-For. This list of hosts can then be used for informational purposes. Previous behavior remains the default one and new one can be triggered by setting a configuration flag server.log-source-ips-full to true. Signed-off-by: julien.girard <julien.girard@ovhcloud.com>
bubu11e
force-pushed
the
souce_ip_full_extract
branch
from
6e41b5d
to
4c4fc76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the ability to extract all hosts from a custom header or the standard one Forwarded, X-Real-IP, X-Forwraded-For.
This list of hosts can then be used for informational purposes.
Previous behavior remains the default one and new one can be triggered by setting a configuration flag
server.log-source-ips-full to true.This PR follow this conversation.