DoUntilQuorum: provide causes when cancelling contexts, and don't log cancellation as an error
#449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esults in a gRPC CANCELED error being returned
charleskorn
force-pushed
the
charleskorn/cancellation-improvements
branch
from
59cde43
to
27cf2ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR improves the handling of context cancellations in
DoUntilQuorum:DoUntilQuorum, that cause will be returned byDoUntilQuorumif it terminates due to cancellation (if no cause is available,context.Cause()will fall back tocontext.Canceled, preserving the existing behaviour)DoUntilQuorumwill provide a cause when cancelling contexts it controlsDoUntilQuorumwill no longer mark the trace span as failed if the call fails due to cancellationNote that this introduces a breaking change to the signature of
DoUntilQuorumWithoutSuccessfulContextCancellation: the function provided must now accept acontext.CancelCauseFuncinstead of acontext.CancelFunc.Which issue(s) this PR fixes:
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]