Fix issue where applying httpgrpc tracing middleware results in all HTTP requests having duplicate trace spans #451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR fixes the issue where applications that use the httpgrpc tracing middleware (through
middleware.InitHTTPGRPCMiddleware
) would have traces for all incoming HTTP calls duplicated.For example, note the duplicate
HTTP POST - api_v1_push
spans in this trace from a Mimir distributor:The fix changes the HTTP middleware to a gRPC interceptor that is then able to accurately filter incoming requests and apply the additional information only to httpgrpc requests.
One downside of this is that we'll convert the request to a
http.Request
twice now: once in the interceptor, and again in the httpgrpc handler, but this seems like the neatest solution.Related: #353
Which issue(s) this PR fixes:
(none)
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]