Export Memcached and Redis client types #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
force-pushed
the
56quarters/cache-export
branch
from
65e3d5f
to
4366966
Compare
56quarters
force-pushed
the
56quarters/cache-export
branch
from
4366966
to
686270c
Compare
Instead of returning the `RemoteCacheClient` interface from their constructors, return the actual type of the client. This lets callers decide how they want to use the clients and not be restricted to only the methods supported by the interface. Part of #452 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/cache-export
branch
from
686270c
to
601af00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Instead of returning the
RemoteCacheClientinterface from their constructors, return the actual type of the client. This lets callers decide how they want to use the clients and not be restricted to only the methods supported by the interface.Which issue(s) this PR fixes:
Part of #452
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]