ring.DoBatch: check context cancellation #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes ring.DoBatch & ring.DoBatchWithOptions to check the context cancellation, as it might take a while to calculate the instances for all keys and sometimes it doesn't make sense to proceed with the callbacks. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
colega
added a commit
to grafana/mimir
that referenced
this pull request
Dec 20, 2023
It may take a while to calculate which instance gets each one of the series (see: grafana/dskit#454) It isn't fair (and is useless) to reach the callback with no ttl. This changes the code to start the timeout once the first callback is called. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
4 tasks
duricanikolic
approved these changes
Dec 20, 2023
colega
commented
Dec 20, 2023
dimitarvdimitrov
approved these changes
Dec 20, 2023
colega
added a commit
to grafana/mimir
that referenced
this pull request
Dec 21, 2023
* Distributor: start remote timeout on first callback It may take a while to calculate which instance gets each one of the series (see: grafana/dskit#454) It isn't fair (and is useless) to reach the callback with no ttl. This changes the code to start the timeout once the first callback is called. Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Update CHANGELOG.md Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Refactor using sync.OnceValues Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> --------- Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This changes ring.DoBatch & ring.DoBatchWithOptions to check the context cancellation, as it might take a while to calculate the instances for all keys and sometimes it doesn't make sense to proceed with the callbacks.
Which issue(s) this PR fixes:
None.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]