Make httpgrpc.Server return 4xx errors #455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duricanikolic
force-pushed
the
yuri/4xx-errors
branch
from
aa95fae
to
20eec26
Compare
duricanikolic
force-pushed
the
yuri/4xx-errors
branch
3 times, most recently
from
1ffbec1
to
37dcc1b
Compare
Signed-off-by: Yuri Nikolic <durica.nikolic@grafana.com>
duricanikolic
force-pushed
the
yuri/4xx-errors
branch
from
37dcc1b
to
a7f7f30
Compare
|
I discourage using an header to enable the behaviour. The feature flag approach is better. I would close this PR in favour of #457. |
|
I am closing this PR in favour of #457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently,
httpgrpc'sServer.Handle()returns an error only if a response received from the HTTP server contains a5xxHTTP status code. Responses with any other HTTP status code (e.g.,4xx) are converted to non-erroneousHTTPResponseobjects. As a consequence, the correlatedstatus_codelabels in the request duration metrics issuccess.This PR allows
Server.Handle()to return errors even in case of a4xxHTTP status code. Namely, the presence of a header with keyhttpgrpc.Return4XXErrorsKeyand any value in a response received from HTTP server indicates toServer.Handle()to convert that response to an error. This way the correlatedstatus_codelabels in the request duration metrics will be4xx.Which issue(s) this PR fixes:
Part of grafana/mimir#1830
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]