Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove grpc routing #460

Merged
merged 3 commits into from
Jan 16, 2024
Merged

Conversation

joe-elliott
Copy link
Member

@joe-elliott joe-elliott commented Jan 5, 2024

This is one of two PRs that go together. See #459 for a full description of changes.

Reverts weaveworks/common#288

@joe-elliott joe-elliott mentioned this pull request Jan 5, 2024
2 tasks
@joe-elliott joe-elliott enabled auto-merge (squash) January 6, 2024 15:10
Copy link
Member

@electron0zero electron0zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to see this go away ✨

Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use this in Mimir, lgtm.

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@joe-elliott joe-elliott merged commit 824e75a into grafana:main Jan 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants