Move requests/hits metrics to cache clients #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
commented
Jan 10, 2024
56quarters
force-pushed
the
56quarters/cache-metrics-again
branch
2 times, most recently
from
35f1c20
to
591442f
Compare
Move tracking of keys requested and hits from the `remoteCache` to each respective cache client (Memcached and Redis). This is part of a refactor that will eventually remove `remoteCache` since it doesn't provide enough value to justify itself. Related #452 Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
force-pushed
the
56quarters/cache-metrics-again
branch
from
591442f
to
ef725ba
Compare
francoposa
approved these changes
Jan 10, 2024
Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Jan 11, 2024
Specifically, pulls in grafana/dskit#465 which is a small refactor of Memcached/Redis clients. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
56quarters
added a commit
to grafana/mimir
that referenced
this pull request
Jan 11, 2024
Specifically, pulls in grafana/dskit#465 which is a small refactor of Memcached/Redis clients. Signed-off-by: Nick Pillitteri <nick.pillitteri@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Move tracking of keys requested and hits from the
remoteCacheto each respective cache client (Memcached and Redis). This is part of a refactor that will eventually removeremoteCachesince it doesn't provide enough value to justify itself.Which issue(s) this PR fixes:
Related #452
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]