Add SpanLogger.SetSpanAndLogTag() method
#467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chencs
reviewed
Jan 12, 2024
charleskorn
added a commit
to grafana/rollout-operator
that referenced
this pull request
Jan 12, 2024
chencs
approved these changes
Jan 12, 2024
charleskorn
added a commit
to grafana/rollout-operator
that referenced
this pull request
Jan 12, 2024
charleskorn
added a commit
to grafana/rollout-operator
that referenced
this pull request
Jan 12, 2024
* Upgrade dskit to bring in the changes from grafana/dskit#467 * Use `SetSpanAndLogTag`. * Add tracing to `zoneTracker`. * Add changelog entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds a
SetSpanAndLogTagmethod toSpanLogger.This is useful for situations where you want to add a tag to a span, and also have this information included in log lines as well.
See grafana/rollout-operator#114 (comment) for the discussion that motivated this functionality.
Which issue(s) this PR fixes:
(none)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]