Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests #1

Merged
merged 3 commits into from
Jan 13, 2022
Merged

Add integration tests #1

merged 3 commits into from
Jan 13, 2022

Conversation

simonswine
Copy link
Collaborator

@simonswine simonswine commented Jan 13, 2022 •
edited

This requires #2 to be merged first

@simonswine simonswine force-pushed the 20220113_integration-test branch 3 times, most recently from bad3364 to 353902f Compare January 13, 2022 10:57
aknuds1
aknuds1 approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@aknuds1 aknuds1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once #2 is merged.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
pracucci
pracucci approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@simonswine simonswine merged commit f226e0b into main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknuds1 aknuds1 aknuds1 approved these changes

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonswine @aknuds1 @pracucci