Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action: add publish npm workflow #10

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Mar 9, 2021

Manually publishing to npm and github is a bit of a painful operation with needing to create auth tokens, editing npmrc between publishings, etc. This is a WIP for getting a github action together for publishing this package automatically when a merge to master occurs that contains a change to the version property in package.json.

WIP as I've never worked with github actions before, not sure if this should live in our github-actions repo, and also requires secrets creating for NPM_TOKEN and GITHUB_TOKEN for the workflow to function.

@jackw jackw self-assigned this Mar 9, 2021
Copy link
Contributor

@mckn mckn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great! Is this something we can share across multiple repos? if not then I think we should keep it in this repo.

@jackw
Copy link
Contributor Author

jackw commented Mar 12, 2021

Yep I'd like to put this somewhere we can share it but I'm not sure how that works. @torkelo do you know if it's possible to share workflows between repos or would I need to re-write this as an action?

@jackw jackw marked this pull request as ready for review March 16, 2021 08:59
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm 🐈

@jackw
Copy link
Contributor Author

jackw commented Jun 14, 2021

@dprokop I apologise for the ping but could you assist me getting this merged so we can automate publishing this package to npmjs and github repositories? I don't have the permissions to add the secrets required for this publish workflow to run.

@jackw jackw merged commit c2dfdc8 into master Jun 16, 2021
@jackw jackw deleted the jackw/publish-action branch June 16, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants