Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Typescript to v4.2.4 #13

Merged
merged 6 commits into from
Apr 28, 2021
Merged

Upgrade Typescript to v4.2.4 #13

merged 6 commits into from
Apr 28, 2021

Conversation

Clarity-89
Copy link
Contributor

Upgrade Typescript to v4.2.4

@Clarity-89 Clarity-89 self-assigned this Apr 28, 2021
@zoltanbedi
Copy link
Member

Can you also upgrade @typescript-eslint/parser at least 4.16.1 please? This way we won't see the incompatibility warning.

@Clarity-89
Copy link
Contributor Author

Can you also upgrade @typescript-eslint/parser at least 4.16.1 please? This way we won't see the incompatibility warning.

I bumped it to the latest version, will that work?

@zoltanbedi
Copy link
Member

Yep that will work, although I think it would be the best to upgrade typescript-eslint/eslint-plugin as well. The only reason I saw because right now there are 2 different versions for the parser.

zoltanbedi
zoltanbedi approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@zoltanbedi zoltanbedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Clarity-89
Copy link
Contributor Author

@zoltanbedi could you help me with publishing the latest version? I haven't done that before.

@Clarity-89 Clarity-89 merged commit 670f15c into master Apr 28, 2021
@zoltanbedi
Copy link
Member

It is just running npm publish but you have to be in the grafana org in npmjs to be able to.

@Clarity-89
Copy link
Contributor Author

It is just running npm publish but you have to be in the grafana org in npmjs to be able to.

Don't think I'm in that org there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoltanbedi zoltanbedi zoltanbedi approved these changes

@mckn mckn Awaiting requested review from mckn

Assignees

@Clarity-89 Clarity-89

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Clarity-89 @zoltanbedi