Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Bump eslint dependencies #23

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Chore: Bump eslint dependencies #23

merged 2 commits into from
Jun 23, 2022

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Jun 23, 2022 •
edited

This PR bumps all dependencies inline with Grafana core and @grafana/toolkit fixing issues where mixed eslint dependencies break linting tasks for plugins.

Related: grafana/grafana/issues/51020

@jackw jackw added the dependencies Pull requests that update a dependency file label Jun 23, 2022
@jackw jackw self-assigned this Jun 23, 2022
ashharrison90
ashharrison90 requested changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

how do we version this package - should this be a major version bump or do we not care? 🤔

ashharrison90
ashharrison90 approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to approve 🤦

@jackw
Copy link
Contributor Author

jackw commented Jun 23, 2022

how do we version this package - should this be a major version bump or do we not care?

Ah good point! According to the readme every change should be considered a major version bump. As this major bumps eslint I'm guessing we'll go with a major bump here too?

leventebalogh
leventebalogh approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🇮🇹

@jackw jackw merged commit 3fd444a into master Jun 23, 2022
@jackw jackw deleted the jackw/bump-deps branch June 23, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leventebalogh leventebalogh leventebalogh approved these changes

@ashharrison90 ashharrison90 ashharrison90 approved these changes

@zoltanbedi zoltanbedi Awaiting requested review from zoltanbedi

Assignees

@jackw jackw

Labels
dependencies Pull requests that update a dependency file
Projects
Plugins Platform
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jackw @leventebalogh @ashharrison90